feat: end to end wiring for per message nack#365
Open
ayildirim21 wants to merge 14 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
==========================================
+ Coverage 92.74% 92.96% +0.22%
==========================================
Files 67 68 +1
Lines 3540 3641 +101
Branches 232 236 +4
==========================================
+ Hits 3283 3385 +102
+ Misses 191 190 -1
Partials 66 66 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ayildirim21
marked this pull request as ready for review
July 7, 2026 07:06
vaibhavtiwari33
requested changes
Jul 7, 2026
Signed-off-by: Vaibhav Tiwari <[email protected]> Signed-off-by: Abdullah Yildirim <[email protected]>
Signed-off-by: Abdullah Yildirim <[email protected]>
Signed-off-by: Abdullah Yildirim <[email protected]>
Signed-off-by: Abdullah Yildirim <[email protected]>
Signed-off-by: Abdullah Yildirim <[email protected]>
Signed-off-by: Abdullah Yildirim <[email protected]>
Signed-off-by: Abdullah Yildirim <[email protected]>
Signed-off-by: Vaibhav Tiwari <[email protected]> Signed-off-by: Abdullah Yildirim <[email protected]>
Signed-off-by: GitHub <[email protected]> Co-authored-by: vaibhavtiwari33 <[email protected]> Signed-off-by: Abdullah Yildirim <[email protected]>
Signed-off-by: Abdullah Yildirim <[email protected]>
ayildirim21
force-pushed
the
per-msg-nack
branch
from
July 21, 2026 09:09
1567031 to
11cc76b
Compare
vaibhavtiwari33
requested changes
Jul 22, 2026
Comment on lines
+12
to
+13
| optional uint64 delay = 3; | ||
| } |
Contributor
There was a problem hiding this comment.
We'll need generic options here as well
Contributor
There was a problem hiding this comment.
Signed-off-by: Abdullah Yildirim <[email protected]>
…ow-python into per-msg-nack
vaibhavtiwari33
approved these changes
Jul 24, 2026
Signed-off-by: Abdullah Yildirim <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #348